Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCIDevice class cleanup #149

Merged
merged 3 commits into from
Oct 15, 2024
Merged

PCIDevice class cleanup #149

merged 3 commits into from
Oct 15, 2024

Conversation

joelsmithTT
Copy link
Contributor

@joelsmithTT joelsmithTT commented Oct 11, 2024 •
edited
Loading

  • Rehome code in pcie/utils.hpp to the PCIDevice class
  • Attempt to clean up ambiguity RE: what "device id" actually means
  • Start enforcing an abstractional boundary at the PCI device level

@joelsmithTT joelsmithTT self-assigned this Oct 11, 2024
@joelsmithTT joelsmithTT marked this pull request as draft October 11, 2024 21:09
@broskoTT broskoTT mentioned this pull request Oct 14, 2024
Closed
@joelsmithTT joelsmithTT force-pushed the joelsmith/147-pcidevice-cleanup branch from 395d470 to 4d71156 Compare October 15, 2024 00:55
@joelsmithTT joelsmithTT marked this pull request as ready for review October 15, 2024 00:57
@joelsmithTT joelsmithTT changed the title Draft: PCIDevice class cleanup PCIDevice class cleanup Oct 15, 2024
pjanevskiTT
pjanevskiTT approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@pjanevskiTT pjanevskiTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, few nit comments

broskoTT
broskoTT reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@broskoTT broskoTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks better now!

@joelsmithTT
PCIDevice cleanup
1ab0621
@joelsmithTT
Generate Doxygen for PCIDevice class
212ebe0 
Also, update the docs/README.md explaining how to add source files to
Doxygen's input.
@joelsmithTT joelsmithTT force-pushed the joelsmith/147-pcidevice-cleanup branch from fe55a8e to 212ebe0 Compare October 15, 2024 17:52
@joelsmithTT joelsmithTT requested a review from broskoTT October 15, 2024 17:52
broskoTT
broskoTT approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@broskoTT broskoTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now!

@joelsmithTT joelsmithTT merged commit 54cefa7 into main Oct 15, 2024
16 checks passed
@joelsmithTT joelsmithTT deleted the joelsmith/147-pcidevice-cleanup branch October 15, 2024 19:43
@joelsmithTT joelsmithTT mentioned this pull request Oct 16, 2024
Merged
This was referenced Nov 6, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broskoTT broskoTT broskoTT approved these changes

@pjanevskiTT pjanevskiTT pjanevskiTT approved these changes

Assignees

@joelsmithTT joelsmithTT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joelsmithTT @broskoTT @pjanevskiTT